[PATCH] D63372: Use "willreturn" function attribute in isGuaranteedToTransferExecutionToSuccessor

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 01:27:43 PDT 2019


jdoerfert added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4290
+      return true;
 
     // FIXME: This isn't aggressive enough; a call which only writes to a global
----------------
Can you keep and modify the comment instead? There are other possibilities specified to improve this and/or the `willreturn` deduction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63372/new/

https://reviews.llvm.org/D63372





More information about the llvm-commits mailing list