[PATCH] D63475: [llvm-readobj] Allow --hex-dump/--string-dump to dump multiple sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: grimar, jhenderson, paulsemel, rupprecht.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

1. `-x foo` currently dumps one `foo`. This change makes it dump all `foo`.
2. `-x foo -x foo` currently dumps `foo` twice. This change makes it dump `foo` once. In addition, if foo has section index 9, `-x foo -x 9` dumps `foo` once.
3. Give a warning instead of an error if `foo` does not exist.

The new behaviors match GNU readelf.

Also, print a new line as a separator between two section dumps.
GNU readelf uses two lines, but one seems good enough.


Repository:
  rL LLVM

https://reviews.llvm.org/D63475

Files:
  test/tools/llvm-readobj/hex-dump-multi.s
  test/tools/llvm-readobj/hex-dump.test
  test/tools/llvm-readobj/print-hex.test
  test/tools/llvm-readobj/string-dump-multi.s
  test/tools/llvm-readobj/string-dump.test
  tools/llvm-readobj/ObjDumper.cpp
  tools/llvm-readobj/ObjDumper.h
  tools/llvm-readobj/llvm-readobj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63475.205254.patch
Type: text/x-patch
Size: 17023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190618/5d4fb082/attachment.bin>