[PATCH] D60974: Clang IFSO driver action.
Puyan Lotfi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 17 19:18:25 PDT 2019
plotfi marked 3 inline comments as done.
plotfi added inline comments.
================
Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:22
+ StringRef Format;
+ std::set<std::string> ParsedTemplates;
+
----------------
MaskRay wrote:
> Does `StringSet<>` work?
It probably could work. I will likely follow up with an NFC patch for this.
================
Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:36
+ };
+ using MangledSymbols = std::map<const NamedDecl *, MangledSymbol>;
+
----------------
MaskRay wrote:
> Are you relying on the ordered property of `std::map`?
No I am not.
================
Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:101
+ return true;
+ if (Symbols.find(ND) != Symbols.end())
+ return true;
----------------
MaskRay wrote:
> `.count`
Nice.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60974/new/
https://reviews.llvm.org/D60974
More information about the llvm-commits
mailing list