[PATCH] D62997: [LV] Share the LV illegality reporting with LoopVectorize. NFC.

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

I agree with Hideki, this could be in LoopVectorize.h.

Also the function overload is confusing, better to just use the same function for all cases.

Once the pattern is done, refactoring is not that hard. If we have overloaded functions, refactoring is a lot harder.

cheers,
--renato



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7339
   if (F->hasFnAttribute(Attribute::NoImplicitFloat)) {
-    LLVM_DEBUG(dbgs() << "LV: Can't vectorize when the NoImplicitFloat"
-                         "attribute is used.\n");
-    ORE->emit(createLVMissedAnalysis(Hints.vectorizeAnalysisPassName(),
-                                     "NoImplicitFloat", L)
-              << "loop not vectorized due to NoImplicitFloat attribute");
+    ::reportVectorizationFailure(
+        "Can't vectorize when the NoImplicitFloat attribute is used",
----------------
hsaito wrote:
> Do we need :: here?
Doesn't make sense to me, given that it should be identical as calling the local function.

Also, this pattern is confusing, better to just use the same helper function on all cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62997/new/

https://reviews.llvm.org/D62997