[PATCH] D63360: hwasan: Use bits [3..11) of the ring buffer entry address as the base stack tag.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 17 14:52:12 PDT 2019
eugenis added inline comments.
================
Comment at: compiler-rt/test/hwasan/TestCases/random-align-right.c:30
// CHECK1: accessing p[20]
+// CHECK1: accessing p[20]
// CHECK1-NEXT: HWAddressSanitizer: tag-mismatch
----------------
why did you copy this line?
================
Comment at: compiler-rt/test/hwasan/TestCases/stack-history-length.c:20
+ // Bump the tag number so that OOB() doesn't end up with tag 0.
+ FUNC();
+
----------------
I don't understand this. How does a single additional call to FUNC help guarantee that property?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63360/new/
https://reviews.llvm.org/D63360
More information about the llvm-commits
mailing list