[PATCH] D63341: [llvm-lipo] Implement -thin

Mon Jun 17 14:32:13 PDT 2019

anushabasana marked 7 inline comments as done.
anushabasana added a comment.

Regarding the error messages, should should they replicate cctools lipo exactly?
Currently have small differences like "no output file specified" vs "thin expects a single output file". 
If so, I can create a separate diff to change all the error messages.

================
Comment at: llvm/tools/llvm-lipo/llvm-lipo.cpp:178
   SmallVector<OwningBinary<Binary>, 1> InputBinaries;
+  // TODO: Add compatibility for archive files
   for (StringRef InputFile : InputFiles) {
----------------
mtrent wrote:
> not really sure what the right protocol for this is in LLVM-land. Should you file a bug in some LLVM-specific bug tracker? Or maybe should you print a warning/error saying a format is not (yet) supported? 
> 
> I thought Archive files were SymbolicFiles and so they "should" be supported, but maybe you're using the wrong level of API? (I could be wrong ... just asking.)
Added an error clarifying that archive files are not yet supported, but we will file a bug to implement this.
We are focusing on object files in this primary implementation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63341/new/

https://reviews.llvm.org/D63341