[PATCH] D63401: SROA: Allow touching addrspacecast with volatile

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D63401#1547107 <https://reviews.llvm.org/D63401#1547107>, @reames wrote:

> In D63401#1546293 <https://reviews.llvm.org/D63401#1546293>, @sanjoy wrote:
>
> > I don't have opinions on this, but Philip might have comments around whether this is okay for GC pointers.
>
>
> No opinion GC wise, but mostly because I don't understand the intent of this patch.  What is the desired outcome here?


For an equivalent bitcast, the type of the underlying alloca is changed into a nicer type and possibly split into multiple allocas (with volatile accesses). I conservatively added checks in r363462 to avoid using the alloca's natural address space for the new operations. I figure it's safer to not change the address space of volatile accesses, but I don't particularly care about this property. InferAddressSpaces avoids changing volatiles, but that was also my idea.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63401/new/

https://reviews.llvm.org/D63401