[PATCH] D60389: FileCheck [9/12]: Add support for matching formats
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 17 14:15:37 PDT 2019
thopre added inline comments.
================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:399
// right value, getUndefVarNames does not return any variable.
+ auto DefNumExpr = FileCheckNumExpr(nullptr, FmtUnsigned);
auto LineVar =
----------------
grimar wrote:
> There is a good practive to avoid using `auto` in case the type isn't obvious.
But isn't it obvious in this case since we see the constructor call?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60389/new/
https://reviews.llvm.org/D60389
More information about the llvm-commits
mailing list