[llvm] r363614 - [AMDGPU] Propagate function attributes thru bitcasts

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 13:42:48 PDT 2019


Author: rampitec
Date: Mon Jun 17 13:42:48 2019
New Revision: 363614

URL: http://llvm.org/viewvc/llvm-project?rev=363614&view=rev
Log:
[AMDGPU] Propagate function attributes thru bitcasts

AMDGPUPropagateAttributes will not work on function bitcatsts,
so move AMDGPUFixFunctionBitcasts before it.

Differential Revision: https://reviews.llvm.org/D63455

Added:
    llvm/trunk/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll
Modified:
    llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp?rev=363614&r1=363613&r2=363614&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp Mon Jun 17 13:42:48 2019
@@ -658,14 +658,15 @@ void AMDGPUPassConfig::addIRPasses() {
   disablePass(&FuncletLayoutID);
   disablePass(&PatchableFunctionID);
 
+  // This must occur before inlining, as the inliner will not look through
+  // bitcast calls.
+  addPass(createAMDGPUFixFunctionBitcastsPass());
+
   // A call to propagate attributes pass in the backend in case opt was not run.
   addPass(createAMDGPUPropagateAttributesEarlyPass(&TM));
 
   addPass(createAtomicExpandPass());
 
-  // This must occur before inlining, as the inliner will not look through
-  // bitcast calls.
-  addPass(createAMDGPUFixFunctionBitcastsPass());
 
   addPass(createAMDGPULowerIntrinsicsPass());
 

Added: llvm/trunk/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll?rev=363614&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll (added)
+++ llvm/trunk/test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll Mon Jun 17 13:42:48 2019
@@ -0,0 +1,23 @@
+; RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+
+; GCN: foo1:
+; v_cndmask_b32_e64 v0, 0, 1, vcc_lo{{$}}
+; GCN: kernel1:
+; GCN: foo1 at gotpcrel32@lo+4
+; GCN: foo1 at gotpcrel32@hi+4
+
+define void @foo1(i32 %x) #1 {
+entry:
+  %cc = icmp eq i32 %x, 0
+  store volatile i1 %cc, i1* undef
+  ret void
+}
+
+define amdgpu_kernel void @kernel1(float %x) #0 {
+entry:
+  call void bitcast (void (i32)* @foo1 to void (float)*)(float %x)
+  ret void
+}
+
+attributes #0 = { nounwind "target-features"="+wavefrontsize32" }
+attributes #1 = { noinline nounwind "target-features"="+wavefrontsize64" }




More information about the llvm-commits mailing list