[PATCH] D61321: [globalisel] Allow SrcOp to convert an APInt and render it as an immediate operand (MO.isImm() == true)
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 17 13:39:07 PDT 2019
arsenm added a comment.
In D61321#1547008 <https://reviews.llvm.org/D61321#1547008>, @aditya_nandakumar wrote:
> In D61321#1546826 <https://reviews.llvm.org/D61321#1546826>, @arsenm wrote:
>
> > We could try to be heroic and use something stronger than unsigned for registers
>
>
>
>
> In D61321#1546826 <https://reviews.llvm.org/D61321#1546826>, @arsenm wrote:
>
> > We could try to be heroic and use something stronger than unsigned for registers
>
>
> Are you talking about using stronger types for registers just in the Builder interface? What would the usage look like? My big concern (besides the massive change this would take) is how verbose it would be to use the APIs.
I mean everywhere, but that's a huge project. I imagine a struct Register { unsigned X; isVirtual(); isPhysical() }
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61321/new/
https://reviews.llvm.org/D61321
More information about the llvm-commits
mailing list