[PATCH] D59909: [X86] Add custom isel to select ADD/SUB/OR/XOR/AND to their non-immediate forms under optsize when the immediate has additional users.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 12:31:12 PDT 2019


spatel added a comment.

In D59909#1544824 <https://reviews.llvm.org/D59909#1544824>, @RKSimon wrote:

> @spatel @andreadb Any comments?


I don't know of any better way to accomplish this, so no objection to the direction. Agree that we should have more tests. Can the addition of tryShrinkShlLogicImm() be an NFC preliminary step?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59909/new/

https://reviews.llvm.org/D59909





More information about the llvm-commits mailing list