[PATCH] D63392: AMDGPU: Explicitly define a triple for some tests

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 12:24:24 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL363600: AMDGPU: Explicitly define a triple for some tests (authored by nha, committed by ).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63392/new/

https://reviews.llvm.org/D63392

Files:
  llvm/trunk/test/CodeGen/AMDGPU/constant-fold-mi-operands.ll
  llvm/trunk/test/CodeGen/AMDGPU/s_addk_i32.ll
  llvm/trunk/test/CodeGen/AMDGPU/s_mulk_i32.ll
  llvm/trunk/test/CodeGen/AMDGPU/sopk-compares.ll
  llvm/trunk/test/CodeGen/AMDGPU/sub.i16.ll


Index: llvm/trunk/test/CodeGen/AMDGPU/sub.i16.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/sub.i16.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/sub.i16.ll
@@ -1,5 +1,5 @@
-; RUN: llc -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=VI -check-prefix=GCN %s
-; RUN: llc -march=amdgcn -mcpu=bonaire -verify-machineinstrs < %s | FileCheck -check-prefix=CI -check-prefix=GCN %s
+; RUN: llc -mtriple=amdgcn--amdhsa -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=VI -check-prefix=GCN %s
+; RUN: llc -mtriple=amdgcn--amdhsa -mcpu=bonaire -verify-machineinstrs < %s | FileCheck -check-prefix=CI -check-prefix=GCN %s
 
 ; FIXME: Need to handle non-uniform case for function below (load without gep).
 ; GCN-LABEL: {{^}}v_test_sub_i16:
Index: llvm/trunk/test/CodeGen/AMDGPU/s_mulk_i32.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/s_mulk_i32.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/s_mulk_i32.ll
@@ -1,5 +1,5 @@
-; RUN: llc -march=amdgcn -mcpu=tahiti -verify-machineinstrs < %s | FileCheck -check-prefix=SI %s
-; RUN: llc -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=SI %s
+; RUN: llc -mtriple=amdgcn--amdpal -mcpu=tahiti -verify-machineinstrs < %s | FileCheck -check-prefix=SI %s
+; RUN: llc -mtriple=amdgcn--amdpal -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=SI %s
 
 ; SI-LABEL: {{^}}s_mulk_i32_k0:
 ; SI: s_load_dword [[VAL:s[0-9]+]]
Index: llvm/trunk/test/CodeGen/AMDGPU/constant-fold-mi-operands.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/constant-fold-mi-operands.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/constant-fold-mi-operands.ll
@@ -1,5 +1,5 @@
-; RUN: llc -march=amdgcn -mcpu=verde -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
-; RUN: llc -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+; RUN: llc -mtriple=amdgcn--amdpal -mcpu=verde -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+; RUN: llc -mtriple=amdgcn--amdpal -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
 
 ; GCN-LABEL: {{^}}fold_mi_v_and_0:
 ; GCN: v_mov_b32_e32 [[RESULT:v[0-9]+]], 0{{$}}
Index: llvm/trunk/test/CodeGen/AMDGPU/s_addk_i32.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/s_addk_i32.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/s_addk_i32.ll
@@ -1,5 +1,8 @@
-; RUN: llc -march=amdgcn -mcpu=tahiti -verify-machineinstrs < %s | FileCheck -check-prefix=SI %s
-; RUN: llc -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=SI %s
+; RUN: llc -mtriple=amdgcn--amdpal -mcpu=tahiti -verify-machineinstrs < %s | FileCheck -check-prefix=SI %s
+; RUN: llc -mtriple=amdgcn--amdpal -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=SI %s
+
+; TODO: Some of those tests fail with OS == amdhsa due to unreasonable register
+;       allocation differences.
 
 ; SI-LABEL: {{^}}s_addk_i32_k0:
 ; SI: s_load_dword [[VAL:s[0-9]+]]
Index: llvm/trunk/test/CodeGen/AMDGPU/sopk-compares.ll
===================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/sopk-compares.ll
+++ llvm/trunk/test/CodeGen/AMDGPU/sopk-compares.ll
@@ -1,5 +1,5 @@
-; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefix=GCN -check-prefix=SI %s
-; RUN: llc -march=amdgcn -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=GCN -check-prefix=VI %s
+; RUN: llc -mtriple=amdgcn--amdpal -mcpu=tahiti -verify-machineinstrs < %s | FileCheck -check-prefix=GCN -check-prefix=SI %s
+; RUN: llc -mtriple=amdgcn--amdpal -mcpu=tonga -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -check-prefix=GCN -check-prefix=VI %s
 
 ; Since this intrinsic is exposed as a constant after isel, use it to
 ; defeat the DAG's compare with constant canonicalizations.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63392.205148.patch
Type: text/x-patch
Size: 4237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/4bb51b41/attachment.bin>


More information about the llvm-commits mailing list