[PATCH] D63122: [llvm-strip] Error when using stdin twice

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht marked an inline comment as done.
rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:85
 
+ErrorSuccess reportWarning(Error E) {
+  assert(E);
----------------
abrachet wrote:
> rupprecht wrote:
> > This doesn't need to have a return value, it should be void.
> This was per @jhenderson’s suggestion, it lets the callback decide wether to continue parsing or not. Of course this one doesn’t do that right now, but allows for it in the future. I don’t have strong feelings either way.
No, rereading that thread, I agree with how it's written. Makes sense to return Error so a different caller could treat warnings as fatal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63122/new/

https://reviews.llvm.org/D63122