[PATCH] D62838: [Object] add isExecutableObject member function

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

(just the one comment, then lgtm)



================
Comment at: llvm/unittests/Object/ObjectFileTest.cpp:83
+  ASSERT_TRUE(!!ObjFileOrErr) << "invalid object file format";
+  ObjPtr = std::move(ObjFileOrErr.get());
+}
----------------
This should just be returned, i.e. the method should have a signature:

```
template <typename HeaderType>
std::unique_ptr<ObjectFile> createObjectFile(const HeaderType &Header, file_magic Magic = file_magic::unknown)
```

(+1 to using the name suggestion from James)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62838/new/

https://reviews.llvm.org/D62838