[PATCH] D63122: [llvm-strip] Error when using stdin twice

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:715
 
 // ParseStripOptions returns the config and sets the input arguments. If a
 // help flag is set then ParseStripOptions will print the help messege and
----------------
abrachet wrote:
> jhenderson wrote:
> > This comment is identical to its declaration, which seems wrong. Could it just be deleted entirely?
> I agree. It was like this before so I figured I would just follow how it was. Should I remove my part or the comment entirely?
- The method is already commented in the header file; the .cpp files don't need comments. (Same for parseObjcopyOptions). They will inevitably go out of sync.
- IMO it's fine to just not update the comment in this patch, and in a separate commit cleanup the header comments.


================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:85
 
+ErrorSuccess reportWarning(Error E) {
+  assert(E);
----------------
This doesn't need to have a return value, it should be void.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63122/new/

https://reviews.llvm.org/D63122