[PATCH] D61494: AMDGPU: Write LDS objects out as global symbols in code generation

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 10:16:59 PDT 2019


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:304-306
+    // LDS variables aren't emitted in HSA or PAL yet.
+    if (OS == Triple::AMDHSA || OS == Triple::AMDPAL)
+      return;
----------------
This breaks the initializer error. This should be moved after


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61494/new/

https://reviews.llvm.org/D61494





More information about the llvm-commits mailing list