[PATCH] D63122: [llvm-strip] Error when using stdin twice

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 09:25:22 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, aside from one comment.



================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:715
 
 // ParseStripOptions returns the config and sets the input arguments. If a
 // help flag is set then ParseStripOptions will print the help messege and
----------------
This comment is identical to its declaration, which seems wrong. Could it just be deleted entirely?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63122/new/

https://reviews.llvm.org/D63122





More information about the llvm-commits mailing list