[PATCH] D63389: [IDF] Generalize IDFCalculator to be used with Clang's CFG

Kristóf Umann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 08:21:06 PDT 2019


Szelethus added a comment.

Thanks!

In D63389#1546185 <https://reviews.llvm.org/D63389#1546185>, @kuhar wrote:

> Looks great, I'm only not sure about the GraphDiff removal.
>
> > Practically revert D50675 <https://reviews.llvm.org/D50675>. This was done because GraphDiff is only specialized for BasicBlock, and wouldn't be used for clang::CFGBlcok. Interestingly, it wasn't even used at all: In D45299 <https://reviews.llvm.org/D45299>, it was used at a certain point (https://reviews.llvm.org/D45299?id=160698) but was ultimately removed. Is this okay?
>
> @asbirlea?


If having a virtual function isn't too painful, it'd be easy to reimplement it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63389/new/

https://reviews.llvm.org/D63389





More information about the llvm-commits mailing list