[PATCH] D63427: AMDGPU/GFX10: Don't generate s_code_end padding in the asm-printer

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 06:09:34 PDT 2019


nhaehnle created this revision.
nhaehnle added reviewers: arsenm, rampitec, t-tye.
Herald added subscribers: tpr, dstuttard, yaxunl, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

The purpose of the padding is to guard against stale code being
fetched into the instruction cache by the lowest level prefetching.
We're generating relocatable ELF here, and so the padding should
arguably be added by the linker. This is in fact what Mesa does.

This also fixes multi-part shaders for Mesa.

Change-Id: I6bfede58f20e9f337762ccf39ef9e0e263e69e82


Repository:
  rL LLVM

https://reviews.llvm.org/D63427

Files:
  lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  test/CodeGen/AMDGPU/s_code_end.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63427.205057.patch
Type: text/x-patch
Size: 6285 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/964c3a04/attachment.bin>


More information about the llvm-commits mailing list