[PATCH] D63424: GlobalISel: Ignore callsite attributes when picking intrinsic type

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: aemerson, paquette, aditya_nandakumar.
Herald added subscribers: Petar.Avramovic, volkan, kristof.beyls, rovka, nhaehnle, wdng, jvesely.

A target intrinsic may be defined as possibly reading memory, but the
call site may have additional knowledge that it doesn't read
memory. The intrinsic lowering will expect the pessimistic assumption
of the intrinsic definition, so the chain should still be used.

      

I fixed the same bug in SelectionDAG in r287593.


https://reviews.llvm.org/D63424

Files:
  lib/CodeGen/GlobalISel/IRTranslator.cpp
  test/CodeGen/AMDGPU/GlobalISel/irtranslator-readnone-intrinsic-callsite.ll


Index: test/CodeGen/AMDGPU/GlobalISel/irtranslator-readnone-intrinsic-callsite.ll
===================================================================
--- /dev/null
+++ test/CodeGen/AMDGPU/GlobalISel/irtranslator-readnone-intrinsic-callsite.ll
@@ -0,0 +1,21 @@
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -global-isel -stop-after=irtranslator -o - %s | FileCheck %s
+
+; Make sure that an intrinsic declaration that has side effects, but
+; called with a readnone call site is translated to
+; G_INTRINSIC_W_SIDE_EFFECTS
+
+; CHECK-LABEL: name: getreg_callsite_attributes
+; CHECK: G_INTRINSIC_W_SIDE_EFFECTS intrinsic(@llvm.amdgcn.s.getreg)
+; CHECK: G_INTRINSIC_W_SIDE_EFFECTS intrinsic(@llvm.amdgcn.s.getreg)
+define amdgpu_kernel void @getreg_callsite_attributes() {
+  %reg0 = call i32 @llvm.amdgcn.s.getreg(i32 0)
+  store volatile i32 %reg0, i32 addrspace(1)* undef
+  %reg1 = call i32 @llvm.amdgcn.s.getreg(i32 0) #1
+  store volatile i32 %reg1, i32 addrspace(1)* undef
+  ret void
+}
+
+declare i32 @llvm.amdgcn.s.getreg(i32) #0
+
+attributes #0 = { nounwind readonly inaccessiblememonly }
+attributes #1 = { nounwind readnone }
Index: lib/CodeGen/GlobalISel/IRTranslator.cpp
===================================================================
--- lib/CodeGen/GlobalISel/IRTranslator.cpp
+++ lib/CodeGen/GlobalISel/IRTranslator.cpp
@@ -1242,8 +1242,10 @@
   if (!CI.getType()->isVoidTy())
     ResultRegs = getOrCreateVRegs(CI);
 
+  // Ignore the callsite attributes. Backend code is most likely not expecting
+  // an intrinsic to sometimes have side effects and sometimes not.
   MachineInstrBuilder MIB =
-      MIRBuilder.buildIntrinsic(ID, ResultRegs, !CI.doesNotAccessMemory());
+      MIRBuilder.buildIntrinsic(ID, ResultRegs, !F->doesNotAccessMemory());
   if (isa<FPMathOperator>(CI))
     MIB->copyIRFlags(CI);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63424.205052.patch
Type: text/x-patch
Size: 1827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/aa6c8765/attachment.bin>