[PATCH] D63076: [ELF][RISCV] Support PLT, GOT, copy and relative relocations
James Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 17 05:06:22 PDT 2019
jrtc27 requested changes to this revision.
jrtc27 added a comment.
This revision now requires changes to proceed.
Still disagree about the behaviour of `R_RISCV_CALL`. You can't just choose the ABI that you want. Please at least put it back to `R_PC`. @ruiu do you have an opinion on this?
================
Comment at: test/ELF/riscv-plt.s:50
+# DIS-NEXT: 11004: jalr ra, ra, 32
+## foo at plt - . = 0x11050-0x1100c = 72
+# DIS-NEXT: auipc ra, 0
----------------
You mean `## foo - . = 0x11020-0x11000 = 32`.
================
Comment at: test/ELF/riscv-plt.s:53
+# DIS-NEXT: 1100c: jalr ra, ra, 72
+## foo at plt - . = 0x11050-0x1100c = 72
+# DIS-NEXT: auipc ra, 0
----------------
You mean `## bar at plt - . = 0x11050-0x11008 = 72`.
================
Comment at: test/ELF/riscv-plt.s:56
+# DIS-NEXT: 11014: jalr ra, ra, 64
+## bar at plt - . = 0x11060-0x1101c = 76
+# DIS-NEXT: auipc ra, 0
----------------
You mean `## bar at plt - . = 0x11050-0x11010 = 64`.
================
Comment at: test/ELF/riscv-plt.s:58
+# DIS-NEXT: auipc ra, 0
+# DIS-NEXT: 1101c: jalr ra, ra, 72
+# DIS: foo:
----------------
No comment for `## weak at plt - . = 0x11060-0x11018 = 72`?
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63076/new/
https://reviews.llvm.org/D63076
More information about the llvm-commits
mailing list