[PATCH] D63405: GlobalISel: Don't lose fneg flags when lowering to fsub

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 04:33:38 PDT 2019


arsenm created this revision.
arsenm added reviewers: mcberg2017, cameron.mcinally, spatel, aemerson, aditya_nandakumar, paquette, volkan.
Herald added subscribers: Petar.Avramovic, kristof.beyls, rovka, nhaehnle, wdng, jvesely.

This was ignoring the flag on fneg, and using the source instruction's
flags which wasn't obviously correct looking to me. I think this is
OK, but should also keep any flags present on the original fneg.

      

Also fixes tests missing from r358702.


https://reviews.llvm.org/D63405

Files:
  lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  test/CodeGen/AMDGPU/GlobalISel/irtranslator-fast-math-flags.ll
  test/CodeGen/AMDGPU/GlobalISel/legalize-fsub.mir
  unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63405.205023.patch
Type: text/x-patch
Size: 5433 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/fc94281c/attachment.bin>


More information about the llvm-commits mailing list