[PATCH] D63394: [yaml2obj][ELF] Suport STT_LOOS, STT_HIOS, STT_LOPROC and STT_HIPROC.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 17 04:32:07 PDT 2019
jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.
Sorry, I don't think this should be done, as these values are just range delimiters, not actually values that a symbol's type can be. If a symbol in that range is required, it should either be specified by the actual value required (e.g. just "11") or with a corresponding specific enumeration value, if available (e.g. STT_MYOS_TYPE).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63394/new/
https://reviews.llvm.org/D63394
More information about the llvm-commits
mailing list