[PATCH] D63189: Test forward references in IntrinsicEmitter on Neon LD(2|3|4)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 04:30:08 PDT 2019


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

In D63189#1543244 <https://reviews.llvm.org/D63189#1543244>, @sdesmalen wrote:

> In D63189#1543227 <https://reviews.llvm.org/D63189#1543227>, @RKSimon wrote:
>
> > is it worth committing the test file with current (trunk) output so this patch shows the diff?
>
>
> The output is expected not to change from this patch. I ran this test with current trunk and it passes, which confirms the behaviour doesn't change with this patch applied.
>  Not sure if there is still any benefit in committing this test separately then?


Agreed - lets keep it in a single commit - thanks for checking. LGTM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63189/new/

https://reviews.llvm.org/D63189





More information about the llvm-commits mailing list