[PATCH] D63338: PHINode: introduce setIncomingValueForBlock() function, and use it.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 04:10:03 PDT 2019

Previous message: [PATCH] D63006: [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto
Next message: [PATCH] D63338: PHINode: introduce setIncomingValueForBlock() function, and use it.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks for updating. I think it would be good to add an assertion as Micheal suggested, as we have similar ones in related functions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63338/new/

https://reviews.llvm.org/D63338

Previous message: [PATCH] D63006: [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto
Next message: [PATCH] D63338: PHINode: introduce setIncomingValueForBlock() function, and use it.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list