[PATCH] D63068: [AVR] Fix incorrect stack parameter push order
Jim Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 16 23:07:04 PDT 2019
Jim added a comment.
@hfinkel
Hi, I am not really sure the means of TokenFactor. I refer the implement of other target.
>From document, TokenFactor is used to represent the fact that the operand operators are independent of each other.
I am not sure why other target transform all stores into one single node by using TokenFactor.
Most of target, it uses sp+offset to store arguments into stack. So the order of store instruction doesn't matter.
In AVR, it uses `push` instruction to store arguments. Therefore. the order of store(push) instruction can't be changed.
Could you give me some suggestion? Thanks.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63068/new/
https://reviews.llvm.org/D63068
More information about the llvm-commits
mailing list