[PATCH] D63393: [llvm-objdump] Remove unnecessary indentation when dumping ELF data.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 16 22:27:35 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s:17
 
 // CHECK:        b:        74 65 73 74 20 73 74 72         test str
 // CHECK-NEXT:  13:        69 6e 67 00                     ing.
----------------
ychen wrote:
> MaskRay wrote:
> > Assume you'll update this part when committing...
> I thought I don't need to. Without this change,  the modified test should fail.
> 
> // CHECK: b: 74 65 73 74 20 73 74 72 test str
>           ^
> <stdin>:2:1: note: scanning from here
> <stdin>:|file format ELF64-x86-64
> ^
> <stdin>:15:2: note: possible intended match here
>  b:| 74 65 73 74 20 73 74 72 test str
>  ^
> 
ok, you probably need `FileCheck --strict-whitespace`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63393/new/

https://reviews.llvm.org/D63393





More information about the llvm-commits mailing list