[PATCH] D61494: AMDGPU: Write LDS objects out as global symbols in code generation

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle marked an inline comment as done.
nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:5571-5572
+    Triple::OSType OS = getTargetMachine().getTargetTriple().getOS();
+    if (OS == Triple::AMDHSA || OS == Triple::AMDPAL)
+      return Op;
+
----------------
arsenm wrote:
> Maybe we can define the intrinsic to return -1 if the size can't be determined, similar to how llvm.objectsize works?
Makes sense, though that seems like a task for a separate change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61494/new/

https://reviews.llvm.org/D61494