[PATCH] D63391: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case) (try 2)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D63391#1545279 <https://reviews.llvm.org/D63391#1545279>, @xbolva00 wrote:

> Thanks, looks fine now (with fixed regression).
>
> Are you going to implement also signed case? And possibly general cases?


I haven't decided yet. I don't have a motivational pattern at hand
as of this moment, and all this handwritten pattern-matching is
so depressingly futile that it is all kinda pointless.

> GCC’s patch contains quite useful details for “general” rem folds, which can help you:
>  https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/expr.c?r1=264248&r2=264247&pathrev=264248

Uhm, is it okay license-wise to look at that code even?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63391/new/

https://reviews.llvm.org/D63391