[PATCH] D63382: [InstCombine] fold a shifted zext to a select

Zvi Rackover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 16 03:54:18 PDT 2019


zvi marked an inline comment as done.
zvi added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp:668-669
   Constant *C1;
   if (match(Op1, m_Constant(C1))) {
     Constant *C2;
     Value *X;
----------------
lebedev.ri wrote:
> I think you want to add the fold here, no reason to restrict it to identical vectors
What is the policy for handling non-splat cases, should they always be handled when possible or are they limited only to certain cases to reduce compile-time?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63382/new/

https://reviews.llvm.org/D63382





More information about the llvm-commits mailing list