[PATCH] D63145: [NFC] Improve triple match of scripts that update tests

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 15 21:58:08 PDT 2019


MaskRay added inline comments.


================
Comment at: utils/UpdateTestChecks/asm.py:322
+  handler = None
+  best_prefix = ""
   for prefix, s in target_handlers.items():
----------------
Single quotes to be consistent with other strings in this file.


================
Comment at: utils/UpdateTestChecks/asm.py:328
+
+  if handler == None:
     raise KeyError('Triple %r is not supported' % (triple))
----------------
`is None`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63145/new/

https://reviews.llvm.org/D63145





More information about the llvm-commits mailing list