[PATCH] D59909: [X86] Add custom isel to select ADD/SUB/OR/XOR/AND to their non-immediate forms under optsize when the immediate has additional users.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 15 06:28:17 PDT 2019


RKSimon added a comment.
Herald added a subscriber: jsji.

@spatel @andreadb Any comments?



================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:3347
+  ConstantSDNode *Cst = dyn_cast<ConstantSDNode>(N1);
+  ConstantSDNode *ShlCst = dyn_cast<ConstantSDNode>(N0->getOperand(1));
+  if (!Cst || !ShlCst)
----------------
auto


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:3571
+
     ConstantSDNode *Cst = dyn_cast<ConstantSDNode>(N1);
+    if (!Cst)
----------------
auto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59909/new/

https://reviews.llvm.org/D59909





More information about the llvm-commits mailing list