[PATCH] D63360: hwasan: Use the lower 8 bits of the ring buffer entry address as the base stack tag.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 13:48:22 PDT 2019


pcc created this revision.
pcc added a reviewer: eugenis.
Herald added subscribers: Sanitizers, hiraditya, kubamracek, srhines.
Herald added projects: Sanitizers, LLVM.

This saves roughly 32 bytes of instructions per function with stack objects
and causes us to preserve enough information that we can recover the original
tags of all stack variables.

Now that stack tags are deterministic (and can never be zero), we no longer
need to pass -hwasan-generate-tags-with-calls during check-hwasan. This also
means that the new stack tag generation mechanism is exercised by check-hwasan.

Depends on D63119 <https://reviews.llvm.org/D63119>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63360

Files:
  compiler-rt/test/hwasan/lit.cfg
  llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
  llvm/test/Instrumentation/HWAddressSanitizer/alloca.ll
  llvm/test/Instrumentation/HWAddressSanitizer/dbg-declare-tag-offset.ll
  llvm/test/Instrumentation/HWAddressSanitizer/kernel-alloca.ll
  llvm/test/Instrumentation/HWAddressSanitizer/prologue.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63360.204843.patch
Type: text/x-patch
Size: 9321 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190614/6590d7fc/attachment.bin>


More information about the llvm-commits mailing list