[PATCH] D63104: Add GSYM utility files along with unit tests.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 13:16:35 PDT 2019


aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/GSYM/InlineInfo.h:41
+  InlineInfo() : Name(0), CallFile(0), CallLine(0) {}
+  void clear() {
+    Name = 0;
----------------
It would be so much easier to reason about correctness if these structs were immutable. Doe we really need a clear() method?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63104/new/

https://reviews.llvm.org/D63104





More information about the llvm-commits mailing list