[PATCH] D63303: [GlobalISel][Localizer] Rewrite localizer to run in 2 phases, inter & intra block.

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 12:11:47 PDT 2019


aemerson marked an inline comment as done.
aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Localizer.cpp:51
+                                MRI->use_instr_nodbg_end());
+    return NumUses < 3;
+  }
----------------
paquette wrote:
> Do we know how this impacts other targets?
I'm not able to test that, but I think that if we're going to improve this pass and accept it's not simply a short term hack, we need to put this into a target cost model.

I'll also change this to not use std::distance but loop until we hit a threshold for compile time reasons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63303/new/

https://reviews.llvm.org/D63303





More information about the llvm-commits mailing list