[PATCH] D63349: [EarlyCSE] Fix hashing of self-compares
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 14 11:53:52 PDT 2019
nikic added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/EarlyCSE.cpp:185
+ CmpInst::Predicate SwappedPred = CI->getSwappedPredicate();
+ if (std::tie(LHS, Pred) > std::tie(RHS, SwappedPred)) {
std::swap(LHS, RHS);
----------------
Would it be possible to make the condition just `Pred > SwappedPred`, without ordering by LHS/RHS at all?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63349/new/
https://reviews.llvm.org/D63349
More information about the llvm-commits
mailing list