[PATCH] D63243: [WIP] Adjust the users of dereferenceable wrt. dereferenceable_globally
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 14 11:06:25 PDT 2019
jdoerfert added inline comments.
================
Comment at: llvm/include/llvm/IR/Value.h:583
+ uint64_t
+ getPointerDereferenceableBytes(const DataLayout &DL, bool &CanBeNull,
+ const Instruction *CtxI = nullptr) const;
----------------
reames wrote:
> An API suggestion. Instead of adding a context pointer here, add a boolean OnlyAtDef out param. Then introduce a helper function in ValueTracking which does the inference over the IR. (i.e. leave this as returning basic facts about the value, and move the analysis into an analysis.)
>
> Or if you want, call the param AssumeNoFree, or whatever..
I like it, done. Though, I do need the location of the definition, so I made it an `Instruction *&` not a `bool &`, what do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63243/new/
https://reviews.llvm.org/D63243
More information about the llvm-commits
mailing list