[PATCH] D63210: gn build: Add NVPTX target

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 10:45:44 PDT 2019


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

Since you always include all three of `//llvm/lib/Target/targets.gni`, `//llvm/lib/Target/targets_with_asm_parsers.gni`, `//llvm/lib/Target/targets_with_disassemblers.gni`, why not just combine all of them into `//llvm/lib/Target/targets.gni`? If we ever need them separately and performance becomes an issue, we can split them later.

LGTM otherwise.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63210/new/

https://reviews.llvm.org/D63210





More information about the llvm-commits mailing list