[PATCH] D63104: Add GSYM utility files along with unit tests.

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked 6 inline comments as done.
clayborg added inline comments.


================
Comment at: include/llvm/DebugInfo/GSYM/FunctionInfo.h:51
+
+  bool isValid() const {
+    // Address and size can be zero and there can be no line entries for a
----------------
JDevlieghere wrote:
> Can we make it so that only valid entries are created, for instance by using an Expected<FunctionInfo> wherever it's created? That way we don't need the isValid and maybe even the clear? This is more of a high level comment that applies to the whole diff. 
Both the DWARF, breakpad, and symbtab converters will create a temp object and then populate, then check if all is good before adding it. It is possible to avoid this, but the code will be cleaner if we can create the object and then populate it lazily. So I would prefer to keep this if possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63104/new/

https://reviews.llvm.org/D63104