[PATCH] D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert requested changes to this revision.
jdoerfert added a comment.
This revision now requires changes to proceed.

What is supposed to happen if the elements in the pointer vector have different underlying objects? 
We need to document that in the comment and test it.



================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:344
+                       "  %a = alloca i64 "
+                       "  %g = getelementptr inbounds i64, i64* %a, <2 x i64> <i64 0, i64 4> "
+                       "  ret <2 x i64*> %g"
----------------
Isn't this index out-of-bounds. If so, that is a problem.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50554/new/

https://reviews.llvm.org/D50554