[PATCH] D63337: [AMDGPU] Don't constrain callees with inlinehint from inlining on MaxBB check to prevent link failure

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 09:19:39 PDT 2019


rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.

LGTM. Not for a correctness, but for the sake of performance. We have been here before, if we restrict inlinehint functions for the compilation speed we are losing too much.
That said, it is also a reasonable w/a for specific issue, although we still need to contact ISV to fix their code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63337/new/

https://reviews.llvm.org/D63337





More information about the llvm-commits mailing list