[llvm] r363408 - [Attributor] Disable the Attributor by default and fix a comment

[Johannes Doerfert via llvm-commits]

Author: jdoerfert
Date: Fri Jun 14 07:53:41 2019
New Revision: 363408

URL: http://llvm.org/viewvc/llvm-project?rev=363408&view=rev
Log:
[Attributor] Disable the Attributor by default and fix a comment

Modified:
    llvm/trunk/include/llvm/Transforms/IPO/Attributor.h
    llvm/trunk/lib/Transforms/IPO/Attributor.cpp

Modified: llvm/trunk/include/llvm/Transforms/IPO/Attributor.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/IPO/Attributor.h?rev=363408&r1=363407&r2=363408&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Transforms/IPO/Attributor.h (original)
+++ llvm/trunk/include/llvm/Transforms/IPO/Attributor.h Fri Jun 14 07:53:41 2019
@@ -97,7 +97,6 @@
 #ifndef LLVM_TRANSFORMS_IPO_ATTRIBUTOR_H
 #define LLVM_TRANSFORMS_IPO_ATTRIBUTOR_H
 
-#include "llvm/Analysis/CGSCCPassManager.h"
 #include "llvm/Analysis/LazyCallGraph.h"
 #include "llvm/IR/CallSite.h"
 #include "llvm/IR/PassManager.h"
@@ -483,8 +482,7 @@ struct BooleanState : public IntegerStat
 /// NOTE: If the state obtained via getState() is INVALID, thus if
 ///       AbstractAttribute::getState().isValidState() returns false, no
 ///       information provided by the methods of this class should be used.
-/// NOTE: The Attributor currently runs as a call graph SCC pass. Partially to
-///       this *current* choice there are certain limitations to what we can do.
+/// NOTE: The Attributor currently has certain limitations to what we can do.
 ///       As a general rule of thumb, "concrete" abstract attributes should *for
 ///       now* only perform "backward" information propagation. That means
 ///       optimistic information obtained through abstract attributes should

Modified: llvm/trunk/lib/Transforms/IPO/Attributor.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/Attributor.cpp?rev=363408&r1=363407&r2=363408&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/Attributor.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/Attributor.cpp Fri Jun 14 07:53:41 2019
@@ -59,7 +59,7 @@ static cl::opt<unsigned>
 static cl::opt<bool> DisableAttributor(
     "attributor-disable", cl::Hidden,
     cl::desc("Disable the attributor inter-procedural deduction pass."),
-    cl::init(false));
+    cl::init(true));
 
 static cl::opt<bool> VerifyAttributor(
     "attributor-verify", cl::Hidden,