[PATCH] D63191: [lld][ELF] Check length of subsection in .ARM.attributes

Fri Jun 14 06:14:27 PDT 2019

peter.smith added a comment.

In D63191#1543464 <https://reviews.llvm.org/D63191#1543464>, @evgeny777 wrote:

> Strange, I haven't got notification. Are buildbot notifications working?
>  Anyway I think making Offset uint64_t instead of size_t will fix the issue.

I think this landed, when the lab.llvm.org was down, we're just catching up. One possible drawback of making Offset uint64_t is that the .ARM.attributes should only be seen in a 32-bit ELF file so there is never a legal attributes section size that large, but I don't think it matters that much. An alternative would be to drop the size field to 0xFE, 0xFF, 0xFF, 0xFF.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63191/new/

https://reviews.llvm.org/D63191