[PATCH] D53283: AMDGPU: Divergence-driven selection of scalar buffer load intrinsics

Fri Jun 14 05:23:43 PDT 2019

hakzsam added a comment.
Herald added a project: LLVM.

Hi Nicolai,

I'm sorry but this change (actually r348050) also breaks World Of Tanks, here's the apitrace https://mega.nz/#!MOg2mSrD!aJHdSrimJBrVzv6c0ParmHDKIsduMq55CKPJjk0OgRI and the DXVK issue is here https://github.com/doitsujin/dxvk/issues/884.
Note that it's not a renderdoc capture because we failed to record one with that game, it worked with apitrace though. The caterpillar issue can be reproduced with both WineD3D/RadeonSI and DXVK/RADV.

The first bad commit is cc436fd26637b0629b95fd8e60fde61cec4b421f, then it works with 69f971eb1814487fc23ee092a69532a8d152c80d (because you reverted the original change) and e3924b1c15606bb5bf98392e0c20e731b4965311 breaks it again.

Can you look into this?
Thanks,
Samuel.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53283/new/

https://reviews.llvm.org/D53283