[PATCH] D63122: [llvm-strip] Error when using stdin twice

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Looks good, aside from the comment.



================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:718-719
 // help flag is set then ParseStripOptions will print the help messege and
-// exit.
-Expected<DriverConfig> parseStripOptions(ArrayRef<const char *> ArgsArr) {
+// exit. ErrorCallback is used to handle recoverable errors, an error value
+// returned by the callback gets returned.
+Expected<DriverConfig>
----------------
Maybe rephrase this slightly:

"handle recoverable errors. An Error returned by the callback aborts the parsing and is then returned by this function"

I'd also move the ErrorCallback description up to its declaration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63122/new/

https://reviews.llvm.org/D63122