[PATCH] D63247: [ARM] MVE VPT Block Pass

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp:369
+
+      const unsigned Mask = 8U;
+      MIBuilder.addImm(Mask);
----------------
SjoerdMeijer wrote:
> samparker wrote:
> > What's 8? Can we use an enum from somewhere?
> That is the Mask Value (0b1000) for the VPST instruction as defined in the ARM ARM, see section B5.6. Predication/conditional execution. I'm not sure there's an enum for this, but will have a look. I will at least rename and comment on the Mask value here.
Ah yes, cheers. Probably worth creating an enum for the values in Table Rvwgt and have it live where ever ARMVCC is defined.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63247/new/

https://reviews.llvm.org/D63247