[PATCH] D63247: [ARM] MVE VPT Block Pass

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added a comment.

> D62669 <https://reviews.llvm.org/D62669> includes a few VPT predicable MVE instructions to test the assembly side of this, is that enough to add some MIR tests for this?

Yep, nice one, will do.



================
Comment at: llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp:369
+
+      const unsigned Mask = 8U;
+      MIBuilder.addImm(Mask);
----------------
samparker wrote:
> What's 8? Can we use an enum from somewhere?
That is the Mask Value (0b1000) for the VPST instruction as defined in the ARM ARM, see section B5.6. Predication/conditional execution. I'm not sure there's an enum for this, but will have a look. I will at least rename and comment on the Mask value here.


================
Comment at: llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp:395
+  bool Modified = false;
+  for (MachineFunction::iterator MFI = Fn.begin(), E = Fn.end(); MFI != E;) {
+    MachineBasicBlock &MBB = *MFI;
----------------
ostannard wrote:
> Can this one be a range-base for loop?
easy piecy lemon squeezy. :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63247/new/

https://reviews.llvm.org/D63247