[PATCH] D63244: Add --undefined-glob which is an --undefined with wildcard pattern match.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 00:09:30 PDT 2019


MaskRay accepted this revision.
MaskRay added a comment.

The code change looks good. Nit about the help text.



================
Comment at: lld/docs/ld.lld.1:509
 .Ar symbol
 to be an undefined symbol during linking.
+.It Fl -undefined-glob Ns = Ns Ar pattern ,
----------------
I was puzzled when I first noticed this option and its help text: `Force to be an undefined symbol during linking.`

If the symbol does not exist, there is no undefined symbol in the link result.
If the symbol is defined, this option does not make the symbol undefined.

Now that you are adding a similar option, maybe revise the documentation a bit to address the confusion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63244/new/

https://reviews.llvm.org/D63244





More information about the llvm-commits mailing list