[PATCH] D63306: Add a remarks-based code size diffing tool

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

Haven't done much of a review, one drive by, but in general I like the idea. Would it make sense to have a general "remarks in object files" tool rather than just a size one? (It can, of course, only do size at the beginning.)

Thoughts?



================
Comment at: llvm/tools/sizediff/sizediff.cpp:238-241
+      "Remark-based size diffing tool.\nThis tool takes in two object files "
+      "produced "
+      "with optimization remarks.\nBoth files must contain a __remarks "
+      "section.\n");
----------------
This looks awkward? Late reformat?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63306/new/

https://reviews.llvm.org/D63306