[PATCH] D63244: Support wildcard patterns in --undefined.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 22:18:03 PDT 2019


ruiu added a comment.

In D63244#1541879 <https://reviews.llvm.org/D63244#1541879>, @jyknight wrote:

> Actually linker scripts do support metacharacter escaping (although, it seems lld does not support this correctly, yet).
>
> E.g., this should match only a function named literally "?"
>
>   VER {
>     global:
>      "?";
>   };
>
>
> While this matches any one-letter function:
>
>   VER {
>     global:
>      ?;
>   };
>
>
> So perhaps this functionality should be given its own command-line argument, e.g. `--undefined-glob`, so as to not cause any such confusion.


I think I like the idea to add this as a new option, instead of changing the meaning of the existing option in a subtle way. I'll give it a new name as you suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63244/new/

https://reviews.llvm.org/D63244





More information about the llvm-commits mailing list